Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and Upgrade to llvm14 #15

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix CI and Upgrade to llvm14 #15

merged 1 commit into from
Oct 17, 2022

Conversation

DerekStrickland
Copy link

This PR adds the changes required to make all the build images CI workflows pass in terms of building the images, and verifying they are all upgraded to LLVM 14. A successful run can be seen here. The PR also includes some small quality of life improvements in terms of code formatting.

These changes were made to support RedBPF #312. The specific changes include:

  • I added Set image name lowercase steps in the publish workflow to lowercase REDBPF_IMAGE_NAME. This was required so that someone like myself who forks and has uppercase letters in their GitHub username can produce docker images with a valid name.
  • Updated Ubuntu 21.04 to 22.04 as 21.04 is now EOL.
  • Updated Fedora 34 to 36
  • Updated Alpine 3.14 to Alpine Edge
  • Updated multiple apt-get install blocks to have one package per line to make visual comparison across files easier
  • In multiple cases I updated the installation script to reference llvm14
  • In multiple cases I added a symlink from the distro specific location of llvm-config-14 to /usr/bin/llvm-config
  • In multiple cases I updated the llvm-config --version check script from 13 to 14
  • Added max_parallel_download=20 and fastestmirror=True to the Fedora dnf.conf to speed up image build times
  • Added emerge-websync to Gentoo to overcome spurious network errors when building
  • Added emerge app-portage/mirrorselect and mirrorselect -s3 -b10 -D -c USA to Gentoo to hopefully speed up build times. I am not sure this is necessary with emerge-webrsync but my Gentoo was non-existent prior to this PR 😺

What I did not do was devise a way to parameterize the llvm version, which seems like a good idea in terms of future maintenance. I can do that in a subsequent PR or this one if desired.

@rsdy
Copy link

rsdy commented Oct 17, 2022

This is great! Can you please sign off all commits according to the DCO policy? I'll be able to merge this then.

Signed-off-by: Derek Strickland <[email protected]>
@DerekStrickland
Copy link
Author

This is great! Can you please sign off all commits according to the DCO policy? I'll be able to merge this then.

Done. Thanks!

@rsdy rsdy merged commit 9a2f078 into foniod:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants